C# Tip: IEnumerable vs ICollection, and why it matters

Just a second! 🫷
If you are here, it means that you are a software developer. So, you know that storage, networking, and domain management have a cost .

If you want to support this blog, please ensure that you have disabled the adblocker for this site. I configured Google AdSense to show as few ADS as possible - I don't want to bother you with lots of ads, but I still need to add some to pay for the resources for my site.

Thank you for your understanding.
- Davide

Defining the best return type is crucial to creating a shared library whose behaviour is totally under your control.

You should give the consumers of your libraries just the right amount of freedom to integrate and use the classes and structures you have defined.

That’s why it is important to know the differences between interfaces like IEnumerable<T> and ICollection<T>: these interfaces are often used together but have totally different meanings.

IEnumerable: loop through the items in the collection

Suppose that IAmazingInterface is an interface you expose so that clients can interact with it without knowing the internal behaviour.

You have defined it this way:

public interface IAmazingInterface
{
    IEnumerable<int> GetNumbers(int[] numbers);
}

As you can see, the GetNumbers returns an IEnumerable<int>: this means that (unless they do some particular tricks like using reflection), clients will only be able to loop through the collection of items.

Clients don’t know that, behind the scenes, AmazingClass uses a custom class MySpecificEnumberable.

public class AmazingClass: IAmazingInterface
{
    public IEnumerable<int> GetNumbers(int[] numbers)
        => new MySpecificEnumberable(numbers);
}

MySpecificEnumberable is a custom class whose purpose is to store the initial values in a sorted way. It implements IEnumerable<int>, so the only operations you have to support are the two implementations of GetEnumerator() - pay attention to the returned data type!

public class MySpecificEnumberable : IEnumerable<int>
{
    private readonly int[] _numbers;

    public MySpecificEnumberable(int[] numbers)
    {
        _numbers = numbers.OrderBy(_ => _).ToArray();
    }

    public IEnumerator<int> GetEnumerator()
    {
        foreach (var number in _numbers)
        {
            yield return number;
        }
    }

    IEnumerator IEnumerable.GetEnumerator()
        => _numbers.GetEnumerator();
}

Clients will then be able to loop all the items in the collection:

IAmazingInterface something = new AmazingClass();
var numbers = something.GetNumbers([1, 5, 6, 9, 8, 7, 3]);

foreach (var number in numbers)
{
    Console.WriteLine(number);
}

But you cannot add or remove items from it.

ICollection: list, add, and remove items

As we saw, IEnumerable<T> only allows you to loop through all the elements. However, you cannot add or remove items from an IEnumerable<T>.

To do so, you need something that implements ICollection<T>, like the following class (I haven’t implemented any of these methods: I want you to focus on the operations provided, not on the implementation details).

class MySpecificCollection : ICollection<int>
{
    public int Count => throw new NotImplementedException();

    public bool IsReadOnly => throw new NotImplementedException();

    public void Add(int item) => throw new NotImplementedException();

    public void Clear() => throw new NotImplementedException();

    public bool Contains(int item) => throw new NotImplementedException();

    public void CopyTo(int[] array, int arrayIndex) => throw new NotImplementedException();

    public IEnumerator<int> GetEnumerator() => throw new NotImplementedException();

    public bool Remove(int item) => throw new NotImplementedException();

    IEnumerator IEnumerable.GetEnumerator() => throw new NotImplementedException();
}

ICollection<T> is a subtype of IEnumerable<T>, so everything we said before is still valid.

However, having a class that implements ICollection<T> gives you full control over how items can be added or removed from the collection, allowing you to define custom behaviour. For instance, you can define that the Add method adds an integer only if it’s an odd number.

Why knowing the difference actually matters

Classes and interfaces are meant to be used. If you are like me, you work on both the creation of the class and its consumption.

So, if an interface must return a sequence of items, you most probably use the List shortcut: define the return type of the method as List<Item>, and then use it, regardless of having it looped through or having the consumer add items to the sequence.

// in the interface
public interface ISomething
{
    List<Item> PerformSomething(int[] numbers);
}


// in the consumer class
ISomething instance = //omitted
List<Item> myItems = instance.PerformSomething([2, 3, 4, 5]);

Everything works fine, but it works because we are in control of both the definition and the consumer.

What if you have to expose the library to something outside your control?

You have to consider two elements:

• consumers should not be able to tamper with your internal implementation (for example, by adding items when they are not supposed to);
• you should be able to change the internal implementation as you wish without breaking changes.

So, if you want your users to just enumerate the items within a collection, you may start this way:

// in the interface
public interface ISomething
{
    IEnumerable<Item> PerformSomething(int[] numbers);
}

// in the implementation

IEnumerable<Item> PerformSomething(int[] numbers)
{
    return numbers.Select(x => new Item(x)).ToList();
}

// in the consumer class

ISomething instance = //omitted
IEnumerable<Item> myItems = instance.PerformSomething([2, 3, 4, 5]);

Then, when the time comes, you can change the internal implementation of PerformSomething with a more custom class:

// custom IEnumerable definition
public class MyCustomEnumberable : IEnumerable<Item> { /*omitted*/ }

// in the interface
IEnumerable<Item> PerformSomething(int[] numbers)
{
    MyCustomEnumberable customEnumerable = new MyCustomEnumberable();
    customEnumerable.DoSomething(numbers);
    return customEnumerable;
}

And the consumer will not notice the difference. Again, unless they try to use tricks to tamper with your code!

This article first appeared on Code4IT 🐧

Wrapping up

While understanding the differences between IEnumerable and ICollection is trivial, understanding why you should care about them is not.

I hope this article helped you understand that yeah, you can take the easy way and return everywhere a List, but it’s a choice that you cannot always apply to a project, and that probably will make breaking changes more frequent in the long run.

I hope you enjoyed this article! Let’s keep in touch on LinkedIn or Twitter! 🤜🤛

Happy coding!

🐧